Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate task summary to chinese #27180

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Translate task summary to chinese #27180

merged 5 commits into from
Nov 1, 2023

Conversation

jiaqiw09
Copy link
Contributor

What does this PR do?

Part of #26803

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests? not necessary

Who can review?

@stevhliu

@jiaqiw09
Copy link
Contributor Author

@stevhliu

here is another pr. it may result in some merge conflict problem as i have another PR is still under review.

You can deal with it later.

Best

stevhliu
stevhliu reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, remember to add this doc to the toctree! 🙂

docs/source/zh/task_summary.md Outdated Show resolved Hide resolved
docs/source/zh/task_summary.md Outdated Show resolved Hide resolved
@jiaqiw09
Copy link
Contributor Author

@stevhliu

hi, thansk for your review. I have fix the reviews and conflict problem.

Best

@jiaqiw09
Copy link
Contributor Author

It seems there is still some problem with yml file. I will fix it later

@jiaqiw09
Copy link
Contributor Author

jiaqiw09 commented Nov 1, 2023

@stevhliu

hi, thansk for your review. I have fixed yml problem.

Best

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! 👍

@stevhliu stevhliu merged commit 239cd0e into huggingface:main Nov 1, 2023
8 checks passed
@jiaqiw09 jiaqiw09 deleted the translate_task_summary branch November 2, 2023 04:46
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
@jiaqiw09 @EduardoPach
Translate task summary to chinese (huggingface#27180)
a71960c 
* translate task_summary.md to chinese

* update translation

* update translation

* fix _toctree.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaqiw09 @HuggingFaceDocBuilderDev @stevhliu