use logger.warning_once to avoid massive outputs #27428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
reviewed
Nov 10, 2023
|
Sure! Happy to do that. If I understand correctly, this will only apply to |
|
@ranchlai Awesome - thanks! Yep, that's right. Feel free to ping with any questions if you're not sure about any of them. |
ranchlai
commented
Nov 13, 2023
| @@ -264,7 +264,9 @@ def __init__(self, config, layer_id=0): | |||
| try: | |||
| load_wkv_cuda_kernel(config.context_length) | |||
| except Exception: | |||
| logger.info("Could not load the custom CUDA kernel for RWKV attention.") | |||
| logger.warning_once( | |||
There was a problem hiding this comment.
@amyeroberts Not quite sure about this. This line is in the init of attention layers.
There was a problem hiding this comment.
In this case, I'd say let's keep it as info as it's really just the exception message, so we want it to be unaffected by the cache.
There was a problem hiding this comment.
OK, will discard this commit
ranchlai
force-pushed
the
update_logging_longformer
branch
from
5e4076c to
d223171
Compare
amyeroberts
approved these changes
Nov 14, 2023
iantbutler01
pushed a commit
to BismuthCloud/transformers
that referenced
this pull request
Dec 16, 2023
* use logger.warning_once to avoid massive outputs when training/finetuning longformer * update more
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
* use logger.warning_once to avoid massive outputs when training/finetuning longformer * update more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a quick fix to to avoid massive outputs when training/finetuning longformer (for text classifcation) by using
logger.warning_oncerather thanlogger.info