Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version of warning notification for get_default_device to v4.38 #27848

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

statelesshz
Copy link
Contributor

@statelesshz statelesshz commented Dec 5, 2023

What does this PR do?

links to #27256

The version of accelerate is verified in the __init__ method:

if not is_accelerate_available():
raise ImportError("Please install accelerate in order to use this tool.")
if model is None:

BTW, correcting several code formatting errors.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc @muellerzr

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's just revert the changes that are unrelated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change and other should not be included

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ArthurZucker I'm not sure why check_code_quality complains when I revert the unrelated changes, could you please take a look?

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Dec 7, 2023

Ah the CI is collecting ruff 0.1.7 , could you try rebasing on main

@statelesshz
Copy link
Contributor Author

@ArthurZucker we got green light :-)

@ArthurZucker ArthurZucker merged commit fc71e81 into huggingface:main Dec 7, 2023
17 checks passed
@ArthurZucker
Copy link
Collaborator

Thanks!

nevikw39 pushed a commit to NTHU-ML-2023-team19/transformers that referenced this pull request Dec 7, 2023
nevikw39 pushed a commit to NTHU-ML-2023-team19/transformers that referenced this pull request Dec 7, 2023
@statelesshz statelesshz deleted the update-warning branch February 8, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants