Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for stochastic depth decay rule in the TimeSformer implementation #27875

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

atawari
Copy link
Contributor

@atawari atawari commented Dec 6, 2023

Fixing typo to correct the stochastic depth decay rule

What does this PR do?

Implementation of drop_path module in TimesformerLayer uses a constant config.drop_path as oppose to stochastic drop path as expected - see comments here and authors implementation here

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Fixing typo to correct the stochastic depth decay rule
@atawari
Copy link
Contributor Author

atawari commented Dec 6, 2023

tagging @amyeroberts as the change is in the vision module.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts amyeroberts merged commit 4b4b864 into huggingface:main Dec 11, 2023
18 checks passed
iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
…huggingface#27875)

Update modeling_timesformer.py

Fixing typo to correct the stochastic depth decay rule
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
…huggingface#27875)

Update modeling_timesformer.py

Fixing typo to correct the stochastic depth decay rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants