Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M4T v2 integration tests #27911

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

ylacombe
Copy link
Contributor

@ylacombe ylacombe commented Dec 8, 2023

What does this PR do?

Some M4T-v2 integration tests are causing GPUs OOM. It happens when we load two models together. I thus shifted some integration tests to half precision which should solve the issue.

cc @ydshieh @ArthurZucker

@ylacombe ylacombe changed the title change dtype of some integration tests Fix M4T v2 integration tests Dec 8, 2023
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot.

When doing such update, always good to verify the tests pass, as the expected value may differ.

(on T4 GPU)

@ylacombe
Copy link
Contributor Author

ylacombe commented Dec 8, 2023

OC, I've already verified that the tests pass (on a 24GB TITAN RTX)! I've also monitored by hand GPU utilization (around 10GB) so I believe it should pass on a 16GB GPU.

FYI, the tests that I've changed verify that every task-specific model has a 1-to-1 correspondence with the task-agnostic model

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks

@ydshieh ydshieh merged commit 5e620a9 into huggingface:main Dec 11, 2023
18 checks passed
@ylacombe ylacombe deleted the shift-m4t-test-fp16 branch December 11, 2023 09:51
iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
change dtype of some integration tests
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
change dtype of some integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants