Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for auto_find_batch_size on multi-GPU #27947

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix test for auto_find_batch_size on multi-GPU #27947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46eaa63
Fix test for multi-GPU
muellerzr Dec 11, 2023
24ef7c5
WIth CPU handle
muellerzr Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/trainer/test_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,7 +1558,7 @@ def test_auto_batch_size_with_resume_from_checkpoint(self):
class MockCudaOOMCallback(TrainerCallback):
def on_step_end(self, args, state, control, **kwargs):
# simulate OOM on the first step
if state.train_batch_size == 16:
if state.train_batch_size >= 16:
raise RuntimeError("CUDA out of memory.")

args = RegressionTrainingArguments(
Expand All @@ -1577,7 +1577,7 @@ def on_step_end(self, args, state, control, **kwargs):
# We can then make a new Trainer
trainer = Trainer(model, args, train_dataset=train_dataset)
# Check we are at 16 to start
self.assertEqual(trainer._train_batch_size, 16)
self.assertEqual(trainer._train_batch_size, 16 * max(trainer.args.n_gpu, 1))
trainer.train(resume_from_checkpoint=True)
# We should be back to 8 again, picking up based upon the last ran Trainer
self.assertEqual(trainer._train_batch_size, 8)
Expand Down
Loading