Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flax BERT] Update deprecated 'split' method #28012

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

sanchit-gandhi
Copy link
Contributor

@sanchit-gandhi sanchit-gandhi commented Dec 13, 2023

What does this PR do?

Fixes #27644. JAX Array split method was deprecated in JAX 0.4.5: https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-5-mar-2-2023

This PR updates the four uses in the codebase to use the (recommended) jnp.split replacement.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sanchit-gandhi sanchit-gandhi merged commit 7e876dc into huggingface:main Dec 15, 2023
18 checks passed
@sanchit-gandhi sanchit-gandhi deleted the jax-lax-split branch December 15, 2023 10:57
iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
* [Flax BERT] Update deprecated 'split' method

* fix copies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when running examples/flax/question-answering
2 participants