Generate: assisted decoding now uses generate for the assistant
#28030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
force-pushed
the
candidate_refactor
branch
from
2033a7b to
132d428
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@amyeroberts the failing test is also failing in the daily CI (i.e. unrelated to this PR, as it doesn't depend on assisted generation), and I can't reproduce it on my end 🤔 |
amyeroberts
reviewed
Dec 14, 2023
amyeroberts
approved these changes
Dec 14, 2023
|
@amyeroberts I can't merge due to the failing test (which is also failing on |
|
(the test is flaky 👉 #28035) |
|
@gante In this case we can merge :) edit: note this was discussed offline as the reason for failing tests was identified and confirmed as independent from this PR |
iantbutler01
pushed a commit
to BismuthCloud/transformers
that referenced
this pull request
Dec 16, 2023
…ggingface#28030) generate refactor
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
…ggingface#28030) generate refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Subset of the original changes in #27979
"Reworks assisted candidate generation to call .generate(), instead of having its own custom generation loop. For most models this is nothing more than a nice abstraction. However, for models with a custom generate() function, this means the assistant model will now make use of it! (🤔 does this mean that DistilWhisper gets better numbers with this refactor?)"
The following tests were run locally and are passing:
RUN_SLOW=1 py.test tests/models/whisper/ -k speculativepy.test tests/ -k test_assisted