Update fixtures-image-utils #28080
Merged
Update fixtures-image-utils #28080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
approved these changes
Dec 15, 2023
amyeroberts
approved these changes
Dec 15, 2023
iantbutler01
pushed a commit
to BismuthCloud/transformers
that referenced
this pull request
Dec 16, 2023
* fix hf-internal-testing/fixtures_image_utils * fix test * comments
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
* fix hf-internal-testing/fixtures_image_utils * fix test * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hf-internal-testing/fixtures_image_utils dataset fixture will break with the next release of datasets .
This dataset has a script that writes cache image files that are used in tests.
But in the next release the dataset is loaded from the Parquet files (so there is no local cache image file anymore).
FYI the issue appears because of new security features:
datasetsnow loads the datasets Parquet exports by default to not let users run dataset scripts if possible.To fix this I opened a PR on to remove the datasets script here: https://huggingface.co/datasets/hf-internal-testing/fixtures_image_utils/discussions/1
And in this PR I pass
revision="refs/pr/1"in the tests to use the fixed dataset fixture and update the tests that rely on it.IMO later we can merge the PR on HF and remove the
revisionargument (if we do this right now it will break tests in the other PRs on github)cc @NielsRogge I think it's impacting tests you implemented