Update VITS modeling to enable ONNX export #28141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarlaix
commented
Dec 19, 2023
ArthurZucker
approved these changes
Dec 20, 2023
In all cases it'll be casted to fp32 (no matter the exponent), using a multiplication instead removes this constraint, and should be "faster" (not that it'll have any impact here) |
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
* Update vits modeling for onnx export compatibility * fix style * Update src/transformers/models/vits/modeling_vits.py
wgifford
pushed a commit
to wgifford/transformers
that referenced
this pull request
Jan 21, 2024
* Update vits modeling for onnx export compatibility * fix style * Update src/transformers/models/vits/modeling_vits.py
AjayP13
pushed a commit
to AjayP13/transformers
that referenced
this pull request
Jan 22, 2024
* Update vits modeling for onnx export compatibility * fix style * Update src/transformers/models/vits/modeling_vits.py
Bowen7
pushed a commit
to Bowen7/transformers
that referenced
this pull request
Mar 11, 2024
* Update vits modeling for onnx export compatibility * fix style * Update src/transformers/models/vits/modeling_vits.py
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the ONNX export of VITS models in Optimum (huggingface/optimum#1607), currently the export is failing due to a cast operator added before the pow operator in the model graph, resulting in an issue during the concatenation of two values of different data type
cc @xenova