Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input_embeds docstring in encoder-decoder architectures #28168

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

gante
Copy link
Member

@gante gante commented Dec 20, 2023

What does this PR do?

Big diff, small change:

  • adds a missing paragraph between the docstring of past_key_values and input_embeds
  • adds missing input_embeds docstring in a few TF models

It chips away some of the diff in #28065

@gante gante requested a review from amyeroberts December 20, 2023 18:58
@@ -1011,10 +1011,11 @@ def __init_subclass__(self):

If `past_key_values` are used, the user can optionally input only the last `decoder_input_ids` (those that
don't have their past key value states given to this model) of shape `(batch_size, 1)` instead of all
`decoder_input_ids` of shape `(batch_size, sequence_length)`. inputs_embeds (`torch.FloatTensor` of shape
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a missing paragraph here 🙃

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all of these!

@gante gante merged commit 7e93ce4 into huggingface:main Dec 21, 2023
@gante gante deleted the input_embeds_doc_fix branch December 21, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants