Update docs around mixing hf scheduler with deepspeed optimizer #28223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Jan 2, 2024
Saibo-creator
pushed a commit
to epfl-dlab/transformers-GCD-PR
that referenced
this pull request
Jan 4, 2024
…ingface#28223) update docs around mixing hf scheduler with deepspeed optimizer
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
…ingface#28223) update docs around mixing hf scheduler with deepspeed optimizer
wgifford
pushed a commit
to wgifford/transformers
that referenced
this pull request
Jan 21, 2024
…ingface#28223) update docs around mixing hf scheduler with deepspeed optimizer
AjayP13
pushed a commit
to AjayP13/transformers
that referenced
this pull request
Jan 22, 2024
…ingface#28223) update docs around mixing hf scheduler with deepspeed optimizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Looks like the docs around mixing and matching deepspeed optimizers with HF schedulers were not updated with #25863. I think there's probably an analogous update to make in
accelerateBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr, @pacman100