-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test marker to run all tests with @require_bitsandbytes #28278
add test marker to run all tests with @require_bitsandbytes #28278
Conversation
Submitting this as a separate PR, to keep things clean/atomic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, works for me, thanks a lot @Titus-von-Koeller !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again ! Note to effectively run bnb tests it is sufficient to just run RUN_SLOW=1 pytest tests/quantization/bnb
as running pytest -m bitsandbytes tests/
will run other tests such as tests that we put on llama etc which are already covered in tests/quantization/bnb
, but this is a good addition anyway so I'd be keen to merge the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! let's just keep the same format for the markers
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Really strange, I just committed the marker description string change that @ArthurZucker suggested, but the tests are failing with unrelated stuff. Maybe the GH Runner doesn't have the right hardware for those tests?
|
Yes it's unrelated to your PR don't worry! |
rebasing on main should suffice to fix this ! |
4fbfa32
to
38a1989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ArthurZucker @ydshieh the CI runner is still failing - I think it uses the former cache that has the un-compatible naten
library installed - #28432 IMO we can move forward and merge
Hmm it seems to fail on other PRs too, e.g. :#28711 |
don't have good idea. i just re-triggered that job and let's see |
38a1989
to
c979585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again !
What does this PR do?
add test marker to run all tests with @require_bitsandbytes
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@younesbelkada, do I need any documentation for this and if yes, where?