Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test marker to run all tests with @require_bitsandbytes #28278

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Titus-von-Koeller
Copy link
Contributor

What does this PR do?

add test marker to run all tests with @require_bitsandbytes

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests? Not needed IMO.

Who can review?

@younesbelkada, do I need any documentation for this and if yes, where?

@Titus-von-Koeller
Copy link
Contributor Author

Submitting this as a separate PR, to keep things clean/atomic.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works for me, thanks a lot @Titus-von-Koeller !

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again ! Note to effectively run bnb tests it is sufficient to just run RUN_SLOW=1 pytest tests/quantization/bnb as running pytest -m bitsandbytes tests/ will run other tests such as tests that we put on llama etc which are already covered in tests/quantization/bnb, but this is a good addition anyway so I'd be keen to merge the PR

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! let's just keep the same format for the markers

pyproject.toml Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Titus-von-Koeller
Copy link
Contributor Author

Really strange, I just committed the marker description string change that @ArthurZucker suggested, but the tests are failing with unrelated stuff. Maybe the GH Runner doesn't have the right hardware for those tests?

FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_generation - RuntimeError: "LayerNormKernelImpl" not implemented for 'Half'
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_audio_classification - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_glue - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_image_classification - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_semantic_segmentation - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_speech_recognition_ctc - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_speech_recognition_ctc_adapter - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_speech_recognition_seq2seq - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).
FAILED examples/pytorch/test_pytorch_examples.py::ExamplesTests::test_run_vit_mae_pretraining - ValueError: FP16 Mixed precision training with AMP or APEX (`--fp16`) and FP16 half precision evaluation (`--fp16_full_eval`) can only be used on CUDA or NPU devices or certain XPU devices (with IPEX).

@ArthurZucker
Copy link
Collaborator

Yes it's unrelated to your PR don't worry!

@ArthurZucker
Copy link
Collaborator

rebasing on main should suffice to fix this !

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ArthurZucker @ydshieh the CI runner is still failing - I think it uses the former cache that has the un-compatible naten library installed - #28432 IMO we can move forward and merge

@younesbelkada
Copy link
Contributor

Hmm it seems to fail on other PRs too, e.g. :#28711

@ydshieh
Copy link
Collaborator

ydshieh commented Feb 2, 2024

don't have good idea. i just re-triggered that job and let's see

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again !

@younesbelkada younesbelkada merged commit 1e402b9 into huggingface:main Feb 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants