Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: install transformers from conda-forge channel #28313

Merged
merged 1 commit into from
Jan 4, 2024
Merged

README: install transformers from conda-forge channel #28313

merged 1 commit into from
Jan 4, 2024

Conversation

kevherro
Copy link
Contributor

@kevherro kevherro commented Jan 2, 2024

What does this PR do?

Switch to the conda-forge channel for transformer installation, as the huggingface channel does not offer the latest version.

Fixes #28248

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we should probably link @LysandreJik's comment from the issue to follow this and mention that the huggingface channel is deprecated for transformers

@kevherro
Copy link
Contributor Author

kevherro commented Jan 3, 2024

@ArthurZucker I appreciate your review!

we should probably link @LysandreJik comment from the issue

"In the future we'll likely remove the huggingface channel support for conda unless we see explicit demand here; if that's the case, please put a thumbs up here (we'll monitor), otherwise, the conda-forge channel is usually very up to date." (here)

mention that the huggingface channel is deprecated for transformers

Good callout. Should this go in the README as well?

@stevhliu
Copy link
Member

stevhliu commented Jan 3, 2024

If you're up for it, would you also mind updating this in the Installation docs? 🙂

Switch to the conda-forge channel for transformer installation,
as the huggingface channel does not offer the latest version.

Fixes #28248
@kevherro
Copy link
Contributor Author

kevherro commented Jan 4, 2024

@stevhliu I think I did this correctly! Note that this also cleans up some whitespaces and newlines in the changed files.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks for also updating across the other languages! 🎉

@stevhliu stevhliu merged commit 5d36025 into huggingface:main Jan 4, 2024
8 checks passed
@kevherro
Copy link
Contributor Author

kevherro commented Jan 4, 2024

My pleasure!

@kevherro kevherro deleted the install-from-conda-forge branch January 4, 2024 18:47
SangbumChoi added a commit to SangbumChoi/transformers that referenced this pull request Jan 5, 2024
@LysandreJik
Copy link
Member

Just seeing this now, but thanks for the PR @kevherro!

staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
)

Switch to the conda-forge channel for transformer installation,
as the huggingface channel does not offer the latest version.

Fixes huggingface#28248
wgifford pushed a commit to wgifford/transformers that referenced this pull request Jan 21, 2024
)

Switch to the conda-forge channel for transformer installation,
as the huggingface channel does not offer the latest version.

Fixes huggingface#28248
AjayP13 pushed a commit to AjayP13/transformers that referenced this pull request Jan 22, 2024
)

Switch to the conda-forge channel for transformer installation,
as the huggingface channel does not offer the latest version.

Fixes huggingface#28248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformers==4.36.2 not available from huggingface conda channel
4 participants