-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: install transformers from conda-forge channel #28313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM we should probably link @LysandreJik's comment from the issue to follow this and mention that the huggingface
channel is deprecated for transformers
@ArthurZucker I appreciate your review!
"In the future we'll likely remove the huggingface channel support for conda unless we see explicit demand here; if that's the case, please put a thumbs up here (we'll monitor), otherwise, the conda-forge channel is usually very up to date." (here)
Good callout. Should this go in the README as well? |
If you're up for it, would you also mind updating this in the Installation docs? 🙂 |
Switch to the conda-forge channel for transformer installation, as the huggingface channel does not offer the latest version. Fixes #28248
@stevhliu I think I did this correctly! Note that this also cleans up some whitespaces and newlines in the changed files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, thanks for also updating across the other languages! 🎉
My pleasure! |
…gface#28313)" This reverts commit 5d36025.
Just seeing this now, but thanks for the PR @kevherro! |
) Switch to the conda-forge channel for transformer installation, as the huggingface channel does not offer the latest version. Fixes huggingface#28248
) Switch to the conda-forge channel for transformer installation, as the huggingface channel does not offer the latest version. Fixes huggingface#28248
) Switch to the conda-forge channel for transformer installation, as the huggingface channel does not offer the latest version. Fixes huggingface#28248
What does this PR do?
Switch to the conda-forge channel for transformer installation, as the huggingface channel does not offer the latest version.
Fixes #28248
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.