Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate support added to Object Detection & Segmentation Models #28315

Closed

Conversation

sam99dave
Copy link

@sam99dave sam99dave commented Jan 2, 2024

What does this PR do?

Fixes #28309

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@NielsRogge

@huggingface huggingface deleted a comment from github-actions bot Feb 2, 2024
@ArthurZucker
Copy link
Collaborator

Hey @sam99dave were you waiting for a review?

@sam99dave
Copy link
Author

sam99dave commented Feb 2, 2024

Yeah, I was waiting for one. Not sure if these required changes has already been merged by another PR. There was another PR for this which was being reviewed I think.

Pls, let me know on this.

@ArthurZucker
Copy link
Collaborator

Seems like #28312 was already approved, but is getting stale. I'll post a message there

Copy link

github-actions bot commented Mar 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@amyeroberts
Copy link
Collaborator

@sam99dave Thanks for opening this PR and contributing to improving our models!

As #28312 was merged in, I'm going to close this PR

@amyeroberts amyeroberts closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leverage Accelerate for object detection/segmentation models
3 participants