Remove token_type_ids from model_input_names (like #24788) #28325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Thanks for fixing this!
Looks fine to me, but let's get a second approval from @ArthurZucker who might know more about reasons for it being added back in previously
ArthurZucker
reviewed
Jan 3, 2024
…d a model reference so that it points to an available model)
|
Thanks for the quick reply! It did fail a test, namely an equality test where the reference output has token_type_ids. It also (catastrophically) failed a test that referenced a closed model. I've removed the offending token_type_ids in the equality check and updated the model reference to an openly available model. It now passes all tests. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Jan 3, 2024
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
…huggingface#28325) * remove token_type_ids from model_input_names (like huggingface#24788) * removed test that assumed token_type_ids should be present and updated a model reference so that it points to an available model)
wgifford
pushed a commit
to wgifford/transformers
that referenced
this pull request
Jan 21, 2024
…huggingface#28325) * remove token_type_ids from model_input_names (like huggingface#24788) * removed test that assumed token_type_ids should be present and updated a model reference so that it points to an available model)
AjayP13
pushed a commit
to AjayP13/transformers
that referenced
this pull request
Jan 22, 2024
…huggingface#28325) * remove token_type_ids from model_input_names (like huggingface#24788) * removed test that assumed token_type_ids should be present and updated a model reference so that it points to an available model)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where the GPTSw3Tokenizer returns token_type_ids. These were not used in training and including them significantly degrades performance. This change is the same fix applied in #24788, which was later (erroneously?) reverted by #23909.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @amyeroberts
Members/contributors who may be interested in your PR:
@DarioSucic @ekgren @bjornrun