Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong xpu device in DistributedType.MULTI_XPU mode #28386

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Fix wrong xpu device in DistributedType.MULTI_XPU mode #28386

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2386a03
remove elif xpu
faaany Jan 8, 2024
073b662
Merge branch 'main' into bug
faaany Jan 11, 2024
734086f
Merge branch 'huggingface:main' into bug
faaany Jan 12, 2024
32817f2
Merge branch 'bug' of https://github.com/faaany/transformers into bug
faaany Jan 12, 2024
c9fa064
remove redudant code
faaany Jan 12, 2024
9026b7e
Merge branch 'huggingface:main' into bug
faaany Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/transformers/training_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,11 +1844,6 @@ def _setup_devices(self) -> "torch.device":
device = torch.device("cuda", local_rank)
self._n_gpu = 1
torch.cuda.set_device(device)
elif is_torch_xpu_available() and "ACCELERATE_USE_XPU" not in os.environ:
os.environ["ACCELERATE_USE_XPU"] = "true"
self.distributed_state = PartialState(timeout=timedelta(seconds=self.ddp_timeout))
device = torch.device("xpu:0")
self._n_gpu = 1
elif is_sagemaker_dp_enabled():
self.distributed_state = PartialState(_use_sagemaker_dp=True)
self._n_gpu = 1
Expand Down Expand Up @@ -1877,12 +1872,6 @@ def _setup_devices(self) -> "torch.device":
elif is_sagemaker_dp_enabled() or is_sagemaker_mp_enabled():
# Already set _n_gpu
pass
elif self.distributed_state.distributed_type == DistributedType.MULTI_XPU:
if "ACCELERATE_USE_XPU" not in os.environ:
os.environ["ACCELERATE_USE_XPU"] = "true"
self._n_gpu = 1
device = torch.device("xpu:0")
torch.xpu.set_device(device)
elif self.distributed_state.distributed_type == DistributedType.NO:
if self.use_mps_device:
warnings.warn(
Expand Down
Loading