Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine xpu device setting #28442

Closed
wants to merge 1 commit into from
Closed

Conversation

zhuhong61
Copy link

@zhuhong61 zhuhong61 commented Jan 11, 2024

We'd like to revise some xpu related logic in device settting.

  1. For MULTI_XPU case, we should set the device according to local rank, instead of to xpu:0 only.
  2. If user set deepspeed config, deepspeed path should be triggered. But current logic will trigger xpu DDP logic not deepspeed. We adjust the order and put deepspeed ahead of xpu.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

* For MULTI_XPU case, set the device according to local rank, instead of to xpu:0

* Put deepspeed ahead of XPU DDP logic
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heavily related to #28386 so good to see!

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants