Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dev setup comments and hints #28495

Merged

Conversation

4imothy
Copy link
Contributor

@4imothy 4imothy commented Jan 14, 2024

What does this PR do?

Changes 'pip install -e .[dev]' -> `pip install -e '.[dev]'` in multiple comments and hints.

New command runs on both zsh and bash, previously it did not work on zsh.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Documentation: @stevhliu and @MKhalusova

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@amyeroberts
Copy link
Collaborator

For the failing tests, you'll need to update the expected strings.

@amyeroberts amyeroberts merged commit ff86bc3 into huggingface:main Jan 15, 2024
22 checks passed
MadElf1337 pushed a commit to MadElf1337/transformers that referenced this pull request Jan 15, 2024
* improve dev setup comments and hints

* fix tests for new dev setup hints
wgifford pushed a commit to wgifford/transformers that referenced this pull request Jan 21, 2024
* improve dev setup comments and hints

* fix tests for new dev setup hints
AjayP13 pushed a commit to AjayP13/transformers that referenced this pull request Jan 22, 2024
* improve dev setup comments and hints

* fix tests for new dev setup hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants