Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max_new_tokens for assistant model in assistant generation #28555

Closed
wants to merge 0 commits into from

Conversation

jmamou
Copy link
Contributor

@jmamou jmamou commented Jan 17, 2024

What does this PR do?

During assistant generation, at each iteration, assistant model generate num_assistant_tokens tokens.

If the maximum numbers of tokens to generate is limited by max_len, in the case that max_len-cur_len is less than num_assistant_tokens, it will be more efficient for the assistant model to generate only max_len-cur_len instead of generating num_assistant_tokens.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@gante
@echarlaix

@jmamou
Copy link
Contributor Author

jmamou commented Jan 17, 2024

It seems that it has been solved yesterday by @ofirzaf #28508 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant