Fix max_new_tokens for assistant model in assistant generation #28555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During assistant generation, at each iteration, assistant model generate
num_assistant_tokens
tokens.If the maximum numbers of tokens to generate is limited by
max_len
, in the case thatmax_len-cur_len
is less thannum_assistant_tokens
, it will be more efficient for the assistant model to generate onlymax_len-cur_len
instead of generatingnum_assistant_tokens
.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@gante
@echarlaix