Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Raise Exception when trying to generate 0 tokens ⚠️ #28621

Merged
merged 7 commits into from
Feb 7, 2024
Merged

⚠️ Raise Exception when trying to generate 0 tokens ⚠️ #28621

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0461c5b
change warning to exception
danielkorat Jan 21, 2024
ab2c8f5
Merge branch 'huggingface:main' into zero-generation-exception
danielkorat Jan 24, 2024
cac29a0
Merge branch 'huggingface:main' into zero-generation-exception
danielkorat Jan 28, 2024
64d6a8c
Update src/transformers/generation/utils.py
danielkorat Jan 28, 2024
ff758af
validate `max_new_tokens` > 0 in `GenerationConfig`
danielkorat Jan 28, 2024
d232326
fix truncation test parameterization in `TextGenerationPipelineTests`
danielkorat Jan 28, 2024
19910d3
Merge branch 'huggingface:main' into zero-generation-exception
danielkorat Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/transformers/generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,11 +1133,10 @@ def _validate_generated_length(self, generation_config, input_ids_length, has_de
)
if input_ids_length >= generation_config.max_length:
input_ids_string = "decoder_input_ids" if self.config.is_encoder_decoder else "input_ids"
warnings.warn(
raise ValueError(
f"Input length of {input_ids_string} is {input_ids_length}, but `max_length` is set to"
f" {generation_config.max_length}. This can lead to unexpected behavior. You should consider"
" increasing `max_new_tokens`.",
UserWarning,
" increasing `max_new_tokens`."
danielkorat marked this conversation as resolved.
Show resolved Hide resolved
)

# 2. Min length warnings due to unfeasible parameter combinations
Expand Down