Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phi-2 requires a disabled autocast in attention layer #28673

Closed
wants to merge 2 commits into from
Closed

Phi-2 requires a disabled autocast in attention layer #28673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9321b2
fix(phi): Disables autocast on PhiAttention layer.
gugarosa Jan 23, 2024
0f7c4ca
chore(docs): Update Phi docs.
gugarosa Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions docs/source/en/model_doc/phi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,10 @@ The original code for Phi-1, Phi-1.5 and Phi-2 can be found [here](https://huggi

<Tip warning={true}>

Phi-2 has been integrated in the development version (4.37.0.dev) of `transformers`. Until the official version is released through `pip`, ensure that you are doing one of the following:
Phi-2 has been integrated in `transformers` 4.37.0 version. If you are using a lower version, ensure that you are doing the following:

* When loading the model, ensure that `trust_remote_code=True` is passed as an argument of the `from_pretrained()` function.

* Update your local `transformers` to the development version: `pip uninstall -y transformers && pip install git+https://github.com/huggingface/transformers`. The previous command is an alternative to cloning and installing from the source.

</Tip>

```python
Expand Down Expand Up @@ -134,8 +132,8 @@ To load and run a model using Flash Attention 2, refer to the snippet below:
>>> from transformers import PhiForCausalLM, AutoTokenizer

>>> # define the model and tokenizer and push the model and tokens to the GPU.
>>> model = PhiForCausalLM.from_pretrained("microsoft/phi-1_5", torch_dtype=torch.float16, attn_implementation="flash_attention_2").to("cuda")
>>> tokenizer = AutoTokenizer.from_pretrained("microsoft/phi-1_5")
>>> model = PhiForCausalLM.from_pretrained("microsoft/phi-2", torch_dtype=torch.float16, attn_implementation="flash_attention_2").to("cuda")
>>> tokenizer = AutoTokenizer.from_pretrained("microsoft/phi-2")

>>> # feel free to change the prompt to your liking.
>>> prompt = "If I were an AI that had just achieved"
Expand Down
3 changes: 3 additions & 0 deletions src/transformers/models/phi/modeling_phi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,9 @@ def _init_rope(self):
else:
raise ValueError(f"Unknown RoPE scaling type {scaling_type}")

# Phi-2 has an attention overflow issue (with FP16) and requires autocast to be disabled
@torch.autocast("cpu", enabled=False)
@torch.autocast("cuda", enabled=False)
def forward(
self,
hidden_states: torch.Tensor,
Expand Down