Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid edge case in audio utils #28836

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

ylacombe
Copy link
Contributor

@ylacombe ylacombe commented Feb 2, 2024

What does this PR do?

Throw an error if the spectrogram is of complex values but mel_filters are passed.

Fixes #27772

cc @sanchit-gandhi @ArthurZucker

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@ylacombe ylacombe merged commit bcd23a5 into huggingface:main Mar 4, 2024
18 checks passed
@ylacombe ylacombe deleted the avoid-silent-error-audio-utils branch March 4, 2024 13:24
damithsenanayake pushed a commit to damithsenanayake/transformers that referenced this pull request Mar 7, 2024
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spectrogram function may silently produce incorrect values for certain inputs
3 participants