Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Spanish translation of task_summary.md #28844

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

aaronjimv
Copy link
Contributor

@aaronjimv aaronjimv commented Feb 2, 2024

What does this PR do?

Add the Spanish version of task_summary.md to transformers/docs/source/es

Fixes #15947

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu

@aaronjimv
Copy link
Contributor Author

Hello. This is a long doc page, so I am open to any feedback. Thanks.

@ArthurZucker
Copy link
Collaborator

Thanks for the PR. Let's try not to ping as many people for this please!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure/format of the docs LGTM! I can't review the content itself since I'm not a native Spanish speaker. Do you know anyone in the ML community who would be interested in contributing and reviewing your work?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@aaronjimv
Copy link
Contributor Author

The structure/format of the docs LGTM! I can't review the content itself since I'm not a native Spanish speaker. Do you know anyone in the ML community who would be interested in contributing and reviewing your work?

Hi @stevhliu, thanks!
@osanseviero has reviewed my work before.

@stevhliu
Copy link
Member

stevhliu commented Feb 7, 2024

For sure, but it’ll probably be faster if there are other community members who can help review your translation since
@osanseviero is pretty busy himself!

Let me see if I can organize something with @mariagrandury and @mrm8488, founders of SomosNLP (an awesome NLP community for Spanish speakers) to help review these translations 🙂

@aaronjimv
Copy link
Contributor Author

For sure, but it’ll probably be faster if there are other community members who can help review your translation since @osanseviero is pretty busy himself!

Let me see if I can organize something with @mariagrandury and @mrm8488, founders of SomosNLP (an awesome NLP community for Spanish speakers) to help review these translations 🙂

Hi @stevhliu thanks for your support, I really appreciate it.
I am attentive to any feedback by SomosNLP 🤗.

@aaronjimv
Copy link
Contributor Author

Hi @stevhliu.
I would like to ask, is there any update on this PR?
I appreciate your help, thanks.

@stevhliu
Copy link
Member

cc @gisturiz, would you be interested in helping review this translation? 🙂

@tadeodonegana
Copy link

Hi! I saw a message from @osanseviero in the SomosNLP community asking for help with the review of a translation.

I would be happy to review it!

@aaronjimv
Copy link
Contributor Author

Hi @tadeodonegana, thanks you! I am open to any feedback.

Copy link

@tadeodonegana tadeodonegana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The translation accurately represents the content of the original English text.

@aaronjimv aaronjimv requested a review from stevhliu February 16, 2024 23:17
@aaronjimv
Copy link
Contributor Author

Thanks for the help @tadeodonegana 😊

@stevhliu let me know is it anything's else, thanks🤗.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much y'all! 🚀

@stevhliu stevhliu merged commit ce4fff0 into huggingface:main Feb 16, 2024
8 checks passed
@aaronjimv aaronjimv deleted the translate_task_summary.md branch February 17, 2024 00:25
Copy link

@KidiIT KidiIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reviewed and approved🫶❤️

Copy link

@KidiIT KidiIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reviewed and approved🫶❤️

zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Feb 19, 2024
* Add task_summary to es/_toctree.yml

* Add task_summary.md to docs/es

* Change title of task_summary.md

* Translate firsts paragraphs

* Translate middle paragraphs

* Translte the rest of the doc

* Edit firts paragraph
itazap pushed a commit that referenced this pull request May 14, 2024
* Add task_summary to es/_toctree.yml

* Add task_summary.md to docs/es

* Change title of task_summary.md

* Translate firsts paragraphs

* Translate middle paragraphs

* Translte the rest of the doc

* Edit firts paragraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Spanish
6 participants