Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test vision encoder-decoder generate #28923

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes #28841. I could not exactly reproduce the failing test, but the issue seems to be the EOS stopping generation earlier than it reaches max_length.

Before adding the fix I checked that EOS was indeed indicated in the generation_config as not None.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@gante

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you for looking into it!

@gante gante requested a review from amyeroberts February 14, 2024 14:27
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this and fixing!

@gante gante merged commit 354775b into huggingface:main Feb 14, 2024
18 checks passed
sbucaille pushed a commit to sbucaille/transformers that referenced this pull request Feb 14, 2024
@zucchini-nlp zucchini-nlp deleted the fix/flaky_test_enc_dec_vision branch February 26, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_encoder_decoder_model_generate for vision_encoder_deocder is flaky
4 participants