[Doc] Fix docbuilder - make BackboneMixin and BackboneConfigMixin importable from utils.
#29002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
changed the title
Doc] Fix docbuilder - make BackboneMixin and BackboneConfigMixin importable from utils.
|
cc @ydshieh |
|
I'm merging as this is quite urgent for resolving failing tests on |
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 14, 2024
…n` importable from `utils`. (huggingface#29002) * Trigger doc build * Test removing references * Importable from utils * Trigger another run on a new commit for testing
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
…n` importable from `utils`. (#29002) * Trigger doc build * Test removing references * Importable from utils * Trigger another run on a new commit for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Several CIs have started having the doc builds failing e.g.:
On one case rerunning lead to a successful build:
However, trying this on other runs wasn't successful e.g.:
I haven't been able to identify why these tests have started failing. Obvious dependencies haven't been affected:
backbones.mdwas touched two weeks agobackbone_utilswas updated three weeks agoThis PR moves the offending backbone classes to be importable from
utils. This was to match all other~utilsreferences in the doc, which have the form~utils.module.object.Doing this appears to have resolved the issue: