Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update important model list #29019

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update important model list #29019

merged 1 commit into from
Feb 16, 2024

Conversation

LysandreJik
Copy link
Member

Adds LLaMa to the important models to test on each commit

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! shall we add mistral as well ?

@LysandreJik
Copy link
Member Author

I hesitated but Mistral and Llama are very close in terms of architecture and support so I didn't find it necessary; do you think it's different enough to warrant being added?

@younesbelkada
Copy link
Contributor

mistral uses sliding window attention which is not the case in llama, for that I thought maybe better to test it but I think all good to leave it as is as well

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for sure. 👍

@LysandreJik LysandreJik merged commit 8876ce8 into main Feb 16, 2024
8 checks passed
@LysandreJik LysandreJik deleted the important-models branch February 16, 2024 10:31
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Feb 19, 2024
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants