Remove static pretrained maps from the library's internals #29112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| @@ -52,8 +43,6 @@ class {{cookiecutter.camelcase_modelname}}Tokenizer(BertTokenizer): | |||
|
|
|||
| vocab_files_names = VOCAB_FILES_NAMES | |||
| pretrained_vocab_files_map = PRETRAINED_VOCAB_FILES_MAP | |||
| max_model_input_sizes = PRETRAINED_POSITIONAL_EMBEDDINGS_SIZES | |||
| pretrained_init_configuration = PRETRAINED_INIT_CONFIGURATION | |||
|
|
|||
| {%- elif cookiecutter.tokenizer_type == "Based on BART" %} | |||
| from ...utils import logging | |||
There was a problem hiding this comment.
The line with
PRETRAINED_POSITIONAL_EMBEDDINGS_SIZES = {
"{{cookiecutter.checkpoint_identifier}}": 1024,
}
should also be removed!
There was a problem hiding this comment.
Correct! This needs to be adapted as well as the "new model addition" script that relies on these. Also there are 5k tests failing that I need to fix before I un-draft it :)
| @@ -53,8 +44,6 @@ class {{cookiecutter.camelcase_modelname}}TokenizerFast(BertTokenizerFast): | |||
|
|
|||
| vocab_files_names = VOCAB_FILES_NAMES | |||
| pretrained_vocab_files_map = PRETRAINED_VOCAB_FILES_MAP | |||
| max_model_input_sizes = PRETRAINED_POSITIONAL_EMBEDDINGS_SIZES | |||
| pretrained_init_configuration = PRETRAINED_INIT_CONFIGURATION | |||
| slow_tokenizer_class = {{cookiecutter.camelcase_modelname}}Tokenizer | |||
|
|
|||
| {%- elif cookiecutter.tokenizer_type == "Based on BART" %} | |||
There was a problem hiding this comment.
let's also cleanup for bart based
pcuenca
added a commit
to huggingface/swift-transformers
that referenced
this pull request
Feb 29, 2024
Fixes distilgpt2 tokenization. Previously, we only used the fallback configuration if there was no `tokenizer_config.json` in the model repo. These files are now being added to some repos in the context of removing dependencies with transformers' internals, like this PR: huggingface/transformers#29112. But only keys removed from the hardcoded rules are being added to minimize potential breaking changes. We now use the fallback config if tokenizer_config.json exists, no tokenizer class is specified, and we do have a fallback config for this architecture.
pcuenca
added a commit
to huggingface/swift-transformers
that referenced
this pull request
Feb 29, 2024
Fixes distilgpt2 tokenization. Previously, we only used the fallback configuration if there was no `tokenizer_config.json` in the model repo. These files are now being added to some repos in the context of removing dependencies with transformers' internals, like this PR: huggingface/transformers#29112. But only keys removed from the hardcoded rules are being added to minimize potential breaking changes. We now use the fallback config if tokenizer_config.json exists, no tokenizer class is specified, and we do have a fallback config for this architecture.
julien-c
reviewed
Mar 5, 2024
LysandreJik
force-pushed
the
remove-maps
branch
2 times, most recently
from
2ce0712
to
dbedf2b
Compare
|
Updated the base to move some of the refactor to that PR: #29534 |
LysandreJik
force-pushed
the
add_pretrained_ids_in_tests
branch
from
e66a3f9
to
9dd29e4
Compare
LysandreJik
force-pushed
the
remove-maps
branch
from
dbedf2b
to
cec1eef
Compare
LysandreJik
force-pushed
the
remove-maps
branch
3 times, most recently
from
5f314cf
to
fbfb0e9
Compare
|
why deprecate vs remove? |
|
Deprecate for 2 months and then simply |
LysandreJik
force-pushed
the
remove-maps
branch
2 times, most recently
from
9e70d94
to
3be48a5
Compare
|
It should be good for review for the brave one @amyeroberts @ArthurZucker. Failing tests are unrelated and also failing on |
There was a problem hiding this comment.
TODO for me, we need to make sure the the test add some pre-trained models to test!
src/transformers/models/deprecated/retribert/tokenization_retribert_fast.py
Show resolved
Hide resolved
Comment on lines
+43
to
+47
| from ..deprecated._archive_maps import ( # noqa: F401, E402 | ||
| DPR_CONTEXT_ENCODER_PRETRAINED_MODEL_ARCHIVE_LIST, # noqa: F401, E402 | ||
| DPR_QUESTION_ENCODER_PRETRAINED_MODEL_ARCHIVE_LIST, # noqa: F401, E402 | ||
| DPR_READER_PRETRAINED_MODEL_ARCHIVE_LIST, # noqa: F401, E402 | ||
| ) |
There was a problem hiding this comment.
Suggested change
| from ..deprecated._archive_maps import ( # noqa: F401, E402 | |
| DPR_CONTEXT_ENCODER_PRETRAINED_MODEL_ARCHIVE_LIST, # noqa: F401, E402 | |
| DPR_QUESTION_ENCODER_PRETRAINED_MODEL_ARCHIVE_LIST, # noqa: F401, E402 | |
| DPR_READER_PRETRAINED_MODEL_ARCHIVE_LIST, # noqa: F401, E402 | |
| ) | |
| from ..deprecated._archive_maps import DPR_CONTEXT_ENCODER_PRETRAINED_MODEL_ARCHIVE_LIST, DPR_QUESTION_ENCODER_PRETRAINED_MODEL_ARCHIVE_LIST, DPR_READER_PRETRAINED_MODEL_ARCHIVE_LIST #fmt skip # noqa: F401, E402 | |
if that works
There was a problem hiding this comment.
prefer to keep it as is as I'll be looking for the suffix when removing these imports
ArthurZucker
approved these changes
Mar 22, 2024
...utter-template-{{cookiecutter.modelname}}/to_replace_{{cookiecutter.lowercase_modelname}}.py
Outdated
Show resolved
Hide resolved
...utter-template-{{cookiecutter.modelname}}/to_replace_{{cookiecutter.lowercase_modelname}}.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
LysandreJik
force-pushed
the
remove-maps
branch
from
a75bb8e
to
2e8ef4b
Compare
hovnatan
pushed a commit
to hovnatan/transformers
that referenced
this pull request
Mar 27, 2024
…ce#29112) * [test_all] Remove static pretrained maps from the library's internals * Deprecate archive maps instead of removing them * Revert init changes * [test_all] Deprecate instead of removing * [test_all] PVT v2 support * [test_all] Tests should all pass * [test_all] Style * Address review comments * Update src/transformers/models/deprecated/_archive_maps.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * Update src/transformers/models/deprecated/_archive_maps.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * [test_all] trigger tests * [test_all] LLAVA * [test_all] Bad rebase --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Merged
4 tasks
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* [test_all] Remove static pretrained maps from the library's internals * Deprecate archive maps instead of removing them * Revert init changes * [test_all] Deprecate instead of removing * [test_all] PVT v2 support * [test_all] Tests should all pass * [test_all] Style * Address review comments * Update src/transformers/models/deprecated/_archive_maps.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * Update src/transformers/models/deprecated/_archive_maps.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * [test_all] trigger tests * [test_all] LLAVA * [test_all] Bad rebase --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.