[CI update] Try to use dockers and no cache
#29202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I mostly need the approval of the security team at this point... |
|
ArthurZucker
commented
May 3, 2024
|
Wow, all ✅ ! I ❤️ seeing this. Will take a look this afternoon. |
ArthurZucker
changed the title
Draft CI update] Try to use dockers and no cacheCI update] Try to use dockers and no cache
LysandreJik
approved these changes
May 3, 2024
Comment on lines
-351
to
-355
| # Might need to add doc-builder and some specific deps in the future | ||
| extras["docs_specific"] = ["hf-doc-builder"] | ||
|
|
||
| # "docs" needs "all" to resolve all the references | ||
| extras["docs"] = extras["all"] + extras["docs_specific"] |
|
(please wait for Yih-Dar's review before merging) |
ydshieh
approved these changes
May 3, 2024
There was a problem hiding this comment.
Thank you @ArthurZucker . This is really great work 🚀 .
Mostly some nit comments, and let discuss/think about the image push process after this being merged.
(Please don't merge yet before I DM you on slack)
Co-authored-by: Lysandre Debut <hi@lysand.re>
Co-authored-by: Lysandre Debut <hi@lysand.re>
Co-authored-by: Lysandre Debut <hi@lysand.re>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
So we have:
1.
setup_and_quality83% faster on average, instead of a total of 11min it's down to 2min36.I think we can do even better with
check repo consistencyby reducing the size of the docker used! (purging nvidia-*, and else not needed for checks). Breakdown:2.
run_testsfrom 17min on average to 6minbefore vs after:
