Disable Mixtral output_router_logits during inference
#29249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonardoEmili
changed the title
output_router_logits during inference
|
Could you run |
|
Thanks for the PR! |
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Set output_router_logits=False in prepare_inputs_for_generation for mixtral * Add output_router_logits=False to prepare_inputs_for_generation for mixtral * Fix style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29087
Before submitting
Pull Request section?
Mixtral inference breaks when
output_router_logits=True#29087documentation guidelines, and
here are tips on formatting docstrings.
No, but I have run
pytest tests/models/mixtral/test_modeling_mixtral.pwhich passed all the non-slow tests.Who can review?
@ArthurZucker