Better SDPA unmasking implementation #29318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
|
fxmarty
commented
Feb 27, 2024
Comment on lines
204
to
205
| if expanded_mask.dtype == torch.bool: | ||
| raise ValueError("AttentionMaskConverter._unmask_unattended expects a float `expanded_mask`, got a BoolTensor.") |
There was a problem hiding this comment.
Some models (gpt bigcode) use bool tensors, but Arthur's implem can't work for that dtype.
There was a problem hiding this comment.
can't we cast it and replace the min with 0?
There was a problem hiding this comment.
For now I expect the cast to be done in the modeling file (explicit).
ArthurZucker
approved these changes
Feb 28, 2024
Comment on lines
204
to
205
| if expanded_mask.dtype == torch.bool: | ||
| raise ValueError("AttentionMaskConverter._unmask_unattended expects a float `expanded_mask`, got a BoolTensor.") |
There was a problem hiding this comment.
can't we cast it and replace the min with 0?
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* better unmask imple * comment * typo * bug report pytorch * cleanup * fix import * add back example * retrigger ci * come on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @ArthurZucker improved the unmasking for SDPA for mem-efficient code path let's do so for all archs using SDPA #27931