Fix remove_columns in text-classification example
#29351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
LGTM, thanks @mariosasko .
(This example script is added in 2023, not the example scripts existing since 2020. That is probably why we don't see any complain until now)
|
@mariosasko Before I ping a core maintainer, could you make sure the doc will be updated on |
|
@ydshieh I've just merged a fix in |
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset.remove_columnsreturns a newDatasetobject instead of modifying the input dataset in-place.Fixes huggingface/datasets#6700