🚨🚨[Whisper Tok] Update integration test #29368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchit-gandhi
commented
Feb 29, 2024
|
|
||
| self.assertListEqual( | ||
| tokenizer.convert_tokens_to_ids(tokens), | ||
| [5723, 307, 257, 220, 31636], | ||
| [5723, 307, 257, 1500], |
There was a problem hiding this comment.
This now gives equivalent results to the original:
from whisper.tokenizer import get_tokenizer
tokenizer = get_tokenizer(True)
tokens = tokenizer.encode("This is a test")
print(tokens)Print Output:
[5723, 307, 257, 1500]
| @@ -499,25 +499,3 @@ def test_offset_decoding(self): | |||
|
|
|||
| output = multilingual_tokenizer.decode(INPUT_TOKENS, output_offsets=True)["offsets"] | |||
| self.assertEqual(output, []) | |||
|
|
|||
| @require_jinja | |||
| def test_tokenization_for_chat(self): | |||
There was a problem hiding this comment.
Chat template doesn't make sense for Whisper (a speech recognition model) - have removed the test to keep the CI lightweight (cc @Rocketknight1)
|
Also cc @ydshieh as this PR will prevent a red CI on |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 1, 2024
ArthurZucker
changed the title
|
The GH PR itself is not strictly breaking (there's no change to the code), but rather it's the Hub PR which is breaking. Fine for me to leave the 🚨 in the title though to book-log this! |
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* [Whisper Tok] Update integration test * make style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The merges for the Whisper tokenizers were updated on the Hub in this PR. While this is a breaking change, it is a required fix to ensure we have parity with the original OpenAI repo.
This PR updates the integration tests for the Whisper tokenizer to reflect the merge changes.