Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fully revert atomic checkpointing 🚨 #29370

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

muellerzr
Copy link
Contributor

@muellerzr muellerzr commented Feb 29, 2024

What does this PR do?

As discussed offline, while on paper having atomic checkpointing was a good idea, it's unmaintainable by the core maintainers and has resulted in an influx of issues from users considering the wide variety of storage options available to them. (and untestable)

As the feature request, while reasonable and from a good mindset, was not due to an outright bug, we are reverting it entirely.

Related PRs:

#27820, #28364

Did revert based on this commit: fe8d130

Related issues:

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @LysandreJik

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That's a good learning experience for me, saving files is tricky and a lot of users have a lot of different hardwares!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Agreed removing this feature is a good idea.

Let's add a 🚨 prefix to the PR title so we know this is a "breaking" change - i.e. behaviour is changing between releases

@muellerzr muellerzr changed the title Fully revert atomic checkpointing 🚨 Fully revert atomic checkpointing 🚨 Mar 4, 2024
@muellerzr muellerzr merged commit 1681a6d into main Mar 4, 2024
21 checks passed
@muellerzr muellerzr deleted the muellerzr-revert-tmpdir branch March 4, 2024 11:17
damithsenanayake pushed a commit to damithsenanayake/transformers that referenced this pull request Mar 7, 2024
@Chandler-Bing
Copy link

wonderful PR! hope 4.38.3 version release soon

@shiningliang
Copy link

Will this change be included in 4.38.3? Thanks

@amyeroberts
Copy link
Collaborator

@Chandler-Bing @shiningliang 4.38.2 -> 4.38.3 would represent a patch release, these are reserved for fixing regressions or unintended breaking changes from a minor release i.e. 4.37 -> 4.38.

We have minor releases roughly once a month, so the next release, 4.39.0 will be in a week or two.

@wxjiao
Copy link

wxjiao commented Mar 19, 2024

Nice PR! Upgraded transformers to the latest version (i.e., main), now the checkpoints can be saved smoothly in mult-node setting.

itazap pushed a commit that referenced this pull request May 14, 2024
Fully revert atomic checkpointing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants