Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper remove forced_decoder_ids for longform generation #29433

Closed
wants to merge 9 commits into from

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes #29287 . As I wrote in the comments to the issue, the error is related to using forced-decoder-ids processor in longform generation, which suppresses all logits to -inf.

i see that forced-decoder-ids will be deprecated, but setting it to None will work for now.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sanchit-gandhi @ArthurZucker

@zucchini-nlp zucchini-nlp changed the title Whisper Whisper remove forced_decoder_ids for longform generation Mar 4, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@sanchit-gandhi sanchit-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me as a quick fix - thanks @zucchini-nlp! I'll open a PR to properly deprecate forced decoder ids as well

@sanchit-gandhi
Copy link
Contributor

I made the full updates in #29485 - feel free to take a look

@zucchini-nlp zucchini-nlp deleted the whisper branch March 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facing issues with sequential long form decoding for long audio
4 participants