Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate: torch.compile-ready generation config preparation #29443

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

gante
Copy link
Member

@gante gante commented Mar 4, 2024

What does this PR do?

Pulled from #29374

This PR changes the code block that prepared the generation config instance so as to be torch.compile(..., fullgraph=True) ready.

@gante gante requested a review from ArthurZucker March 4, 2024 14:19
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit, if the kwargs is already in the generation config with the same value no need to raise errors

src/transformers/generation/utils.py Outdated Show resolved Hide resolved
@gante gante merged commit ddb4fda into huggingface:main Mar 6, 2024
21 checks passed
@gante gante deleted the config_preparation_compile branch March 6, 2024 14:28
damithsenanayake pushed a commit to damithsenanayake/transformers that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants