Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UDOP] Fix tests #29573

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[UDOP] Fix tests #29573

merged 3 commits into from
Apr 10, 2024

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

This PR fixes the failing slow tests for UDOP.

@NielsRogge NielsRogge requested a review from ydshieh March 10, 2024 20:44
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ydshieh
ydshieh approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ydshieh ydshieh requested a review from amyeroberts March 15, 2024 08:26
amyeroberts
amyeroberts reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on fixing these!

Just a question about the model implementation and how it relates to the tests

tests/models/udop/test_modeling_udop.py Outdated Show resolved Hide resolved
tests/models/udop/test_modeling_udop.py Outdated Show resolved Hide resolved
@huggingface huggingface deleted a comment from github-actions bot Apr 10, 2024
@ydshieh ydshieh requested a review from amyeroberts April 10, 2024 08:58
amyeroberts
amyeroberts approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NielsRogge NielsRogge merged commit 50c1c19 into huggingface:main Apr 10, 2024
18 checks passed
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
@NielsRogge @ArthurZucker
[UDOP] Fix tests (#29573)
c3c69d7 
* Fix tests

* Fix tests

* Remove no_split_modules
itazap pushed a commit that referenced this pull request May 14, 2024
@NielsRogge
[UDOP] Fix tests (#29573)
a0c0eb0 
* Fix tests

* Fix tests

* Remove no_split_modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

@ydshieh ydshieh ydshieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NielsRogge @HuggingFaceDocBuilderDev @ydshieh @amyeroberts