Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow apply_chat_template to pass kwargs to the template and support a dict of templates #29658

Merged
merged 11 commits into from
Mar 14, 2024
Merged

Allow apply_chat_template to pass kwargs to the template and support a dict of templates #29658

merged 11 commits into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. Allow apply_chat_template to pass kwargs to the template

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1e908c7 View commit details
    Browse the repository at this point in the history

  2. Fix priority for template_kwargs

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    024f786 View commit details
    Browse the repository at this point in the history

  3. Fix docstring

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0222077 View commit details
    Browse the repository at this point in the history

  4. style fix

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2cb238c View commit details
    Browse the repository at this point in the history

  5. Add the option for the model to have a dict of templates

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1df5db7 View commit details
    Browse the repository at this point in the history

  6. Error message cleanup

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6a39d6c View commit details
    Browse the repository at this point in the history

  7. Add test for chat template dicts

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8d9789c View commit details
    Browse the repository at this point in the history

  8. Simplify the chat template dict test and apply it to all tokenizers i… 

    …n self.get_tokenizers()
    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    53ca0fb View commit details
    Browse the repository at this point in the history

  9. Save chat template dicts as lists with fixed key names

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6b71e6e View commit details
    Browse the repository at this point in the history

  10. Add test for serialization/reloading

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e814006 View commit details
    Browse the repository at this point in the history

  11. Add require_jinja just to be safe, even though I don't think we use it

    @Rocketknight1
    Rocketknight1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    97442a6 View commit details
    Browse the repository at this point in the history