Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI / generate: batch size computation compatible with all models #29671

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

gante
Copy link
Member

@gante gante commented Mar 15, 2024

What does this PR do?

Fixes the CI issues in musicgen.

The following tests were run locally (with the expected tests passing):

  1. py.test tests/models/musicgen/test_modeling_musicgen.py -vv
  2. RUN_SLOW=1 py.test tests/models/llama/test_modeling_llama.py -vv [because the failing changes were initially made for this model]

@gante gante requested a review from ydshieh March 15, 2024 10:00
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, the logic is changed from attention_mask to inputs_embeds but I trust you.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@gante gante merged commit bf3dfd1 into huggingface:main Mar 18, 2024
21 checks passed
@gante gante deleted the cur_len_input_embeds branch March 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants