Fix wrong condition used in filter_models
#29673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Mar 15, 2024
| @@ -1244,7 +1244,7 @@ def parse_commit_message(commit_message: str) -> Dict[str, bool]: | |||
| args.output_file, | |||
| diff_with_last_commit=diff_with_last_commit, | |||
| json_output_file=args.json_output_file, | |||
| filter_models=(not commit_flags["no_filter"] or is_main_branch), | |||
There was a problem hiding this comment.
the previous one here was wrong: this actually filter whenever it is on main branch.
|
Happens to the best of us, @ydshieh! Thank you for fixing 💛 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
update Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My previous #28816 used a stupid wrong condition.
The correct one should be : we don't want to filter when we are on
mainbranch.I am so bad at boolean op, sorry
cc @gante