Reset alarm signal when the function is ended #29706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -614,6 +615,10 @@ def resolve_trust_remote_code(trust_remote_code, model_name, has_local_code, has | |||
| f"load the model. You can inspect the repository content at https://hf.co/{model_name}.\n" | |||
| f"Please pass the argument `trust_remote_code=True` to allow custom code to be run." | |||
| ) | |||
| finally: | |||
| if prev_sig_handler is not None: | |||
| signal.signal(signal.SIGALRM, prev_sig_handler) | |||
There was a problem hiding this comment.
this will restore to the signal before the try not to the signal before load_custom_code. Should we not store signal.getsignal(signal.SIGALRM) before all that?
There was a problem hiding this comment.
Sorry, I didn't find where load_custom_code is, but I don't think we should reset it here.
Yeah, it's not easy to reproduce, but I've reproduced it, please see the newest comment in the issue #29690 (comment) |
ArthurZucker
approved these changes
Mar 30, 2024
| @@ -614,6 +615,10 @@ def resolve_trust_remote_code(trust_remote_code, model_name, has_local_code, has | |||
| f"load the model. You can inspect the repository content at https://hf.co/{model_name}.\n" | |||
| f"Please pass the argument `trust_remote_code=True` to allow custom code to be run." | |||
| ) | |||
| finally: | |||
| if prev_sig_handler is not None: | |||
| signal.signal(signal.SIGALRM, prev_sig_handler) | |||
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29690
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?