Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter_models #29710

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Fix filter_models #29710

merged 4 commits into from
Mar 18, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Mar 18, 2024 •
edited
Loading

Fix #29683

What does this PR do?

#29682 is reverted because, when there are many files impacted and filter_models=False, the argument to pytest is too long, and fetch_tests job on Circle fails with /bin/bash: line 25: /usr/bin/jq: Argument list too long.

This PR avoids this situation by using a heuristic of 30 models. If there are more than 30 models being impacted +filter_models=False, we will trigger a full CI by using tests as the target.

See the file tests_fetched_summary.txt in

https://app.circleci.com/pipelines/github/huggingface/transformers/87349/workflows/3a84543d-d965-416d-81f7-eee0286e30c7/jobs/1134895/artifacts

More than 30 models are impacted and `filter_models=False`. CI is configured to test everything.

### TEST TO RUN ###
- tests

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

amyeroberts
amyeroberts approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Seems like a reasonable heuristic which we can easily adjust

utils/tests_fetcher.py Outdated Show resolved Hide resolved
utils/tests_fetcher.py Outdated Show resolved Hide resolved
@ydshieh ydshieh merged commit 87e2ea3 into main Mar 18, 2024
8 checks passed
@ydshieh ydshieh deleted the fix_fix_fix branch March 18, 2024 13:32
@ydshieh ydshieh mentioned this pull request Apr 16, 2024
Closed
itazap pushed a commit that referenced this pull request May 14, 2024
@ydshieh
Fix filter_models (#29710)
7e5ceb0 
* update

* update

* update

* check

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use a subset in test fetcher if on main branch
3 participants
@ydshieh @HuggingFaceDocBuilderDev @amyeroberts