Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quality] update quality check to make sure we check imports 😈 #29771

Merged
merged 7 commits into from
Mar 22, 2024
Merged

[quality] update quality check to make sure we check imports 😈 #29771

merged 7 commits into from
Mar 22, 2024

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Update the quality check

@ArthurZucker ArthurZucker marked this pull request as ready for review March 21, 2024 06:51
LysandreJik
LysandreJik approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome with the upcoming exit 1 :)

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit e68ff30 into main Mar 22, 2024
8 checks passed
@ArthurZucker ArthurZucker deleted the add-import-test branch March 22, 2024 09:12
itazap pushed a commit that referenced this pull request May 14, 2024
@ArthurZucker
[quality] update quality check to make sure we check imports 😈 (#29771
bb3fc15 
)

* update quality check

* make it nice

* update

* let's make sure it runs and we have the logs actually

* update workflow

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurZucker @HuggingFaceDocBuilderDev @LysandreJik