[LlamaSlowConverter] Slow to Fast better support
#29797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
4 tasks
2 tasks
amyeroberts
approved these changes
Mar 28, 2024
Comment on lines
+1334
to
+1336
| (self.original_tokenizer.convert_ids_to_tokens(0), 0.0), | ||
| (self.original_tokenizer.convert_ids_to_tokens(1), 0.0), | ||
| (self.original_tokenizer.convert_ids_to_tokens(2), 0.0), |
There was a problem hiding this comment.
I'm assuming having the mapping of ids to tokens here is fine because we're always handling Llama in this case?
ArthurZucker
commented
Mar 28, 2024
amyeroberts
pushed a commit
that referenced
this pull request
Mar 28, 2024
* fix * fix test * style * nit * rather rely on concert token to id * fix quality * Update src/transformers/convert_slow_tokenizer.py
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* fix * fix test * style * nit * rather rely on concert token to id * fix quality * Update src/transformers/convert_slow_tokenizer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes sur that the eos token, bos token and unk token are correctly taken when initializing from slow.
Fixes #29774, fixes #29836