Remove deprecated properties in tokenization_nllb.py and tokenization_nllb_fast.py

[ymoslem]

What does this PR do?

This PR fixes a typo in a warning in two tokenization files for the NLLB model. It changes adder_tokens_decoder into added_tokens_decoder and improves the warning's readability.

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• Did you read the contributor guideline,
  Pull Request section?
• Was this discussed/approved via a Github issue or the forum? Please add a link
  to it if that's the case.
• Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

• tokenizers: @ArthurZucker

[amyeroberts]

Hi @ymoslem, thanks for opening this PR!

What I would suggest is actually just removing these properties altogether, as they're deprecated and we're now on v4.39

[ymoslem]

Thanks @amyeroberts! Okay, I removed the deprecated properties, but some tests failed like this one. Should I edit it too?

transformers/tests/models/nllb/test_tokenization_nllb.py

Lines 370 to 373 in 76a33a1

	def test_language_codes(self):
	self.assertEqual(self.tokenizer.fairseq_tokens_to_ids["ace_Arab"], 256001)
	self.assertEqual(self.tokenizer.fairseq_tokens_to_ids["ace_Latn"], 256002)
	self.assertEqual(self.tokenizer.fairseq_tokens_to_ids["fra_Latn"], 256057)

[amyeroberts]

@ymoslem Yep - if we've deprecated a method, it's OK to remove from the tests here

[ArthurZucker]

Hey! Thanks, are you still working on this? Could you rebase and fix the test so we can merge! 🤗

[ymoslem]

Hi @ArthurZucker I think it is fixed now. Please let me know if I should do something else. Thanks!

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[ymoslem]

Review required.

[ArthurZucker]

Thanks for updating!

[ArthurZucker]

COuld you rebase your branch to make sure we don't have any issues? 🤗

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[ymoslem]

Now, it is synched with the latest repository. @ArthurZucker

[ArthurZucker]

can you push the merge here? 😉

[ArthurZucker]

Thanks!