Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement "Automatic safetensors conversion when lacking these files" #29846

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Mar 25, 2024

PR #29390 was reverted as it was failing in users' runtime.

Two past issues:

This PR enables it with a slight change: all exceptions can be caught and ignored so as to leave the user's runtime alone.

LysandreJik and others added 2 commits March 25, 2024 09:46
* Automatic safetensors conversion when lacking these files

* Remove debug

* Thread name

* Typo

* Ensure that raises do not affect the main thread
@LysandreJik LysandreJik marked this pull request as ready for review March 25, 2024 09:15
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you link the two issues that raised the failures? 🤗

@LysandreJik LysandreJik merged commit 4d8427f into main Mar 27, 2024
21 checks passed
@LysandreJik LysandreJik deleted the safetensors-step-2 branch March 27, 2024 07:58
itazap pushed a commit that referenced this pull request May 14, 2024
…s" (#29846)

* Automatic safetensors conversion when lacking these files (#29390)

* Automatic safetensors conversion when lacking these files

* Remove debug

* Thread name

* Typo

* Ensure that raises do not affect the main thread

* Catch all errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants