-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beam search visualizer to the doc #29876
Add beam search visualizer to the doc #29876
Conversation
@gante I've added a reference were you pointed, and a shorter one in the intro where beam-search was described. If you prefer we can remove the shortest. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would even add a screen / gif of what it looks like! Great work over there! 🤗
Thanks a lot @ArthurZucker ! PR to add an image to the doc dataset open here: https://huggingface.co/datasets/huggingface/documentation-images/discussions/305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@aymeric-roucher I'm assuming you want to expand the current PR to include the image added here?
03eb940
to
5735722
Compare
@gante I just amended the commit to include the image! |
5735722
to
f8b2ded
Compare
f8b2ded
to
98f2768
Compare
It's ok to merge on my side @gante ! |
What does this PR do?
Add this visualization tool for beam-search to the documentation.
Who can review?
@gante