Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beam search visualizer to the doc #29876

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

aymeric-roucher
Copy link
Contributor

What does this PR do?

Add this visualization tool for beam-search to the documentation.

Who can review?

@gante

@aymeric-roucher
Copy link
Contributor Author

@gante I've added a reference were you pointed, and a shorter one in the intro where beam-search was described. If you prefer we can remove the shortest.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even add a screen / gif of what it looks like! Great work over there! 🤗

@aymeric-roucher
Copy link
Contributor Author

Thanks a lot @ArthurZucker ! PR to add an image to the doc dataset open here: https://huggingface.co/datasets/huggingface/documentation-images/discussions/305

@ArthurZucker ArthurZucker requested a review from gante March 27, 2024 02:35
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@aymeric-roucher I'm assuming you want to expand the current PR to include the image added here?

@aymeric-roucher aymeric-roucher force-pushed the beam-search-visualizer branch from 03eb940 to 5735722 Compare March 27, 2024 15:58
@aymeric-roucher
Copy link
Contributor Author

@gante I just amended the commit to include the image!

@aymeric-roucher aymeric-roucher force-pushed the beam-search-visualizer branch from 5735722 to f8b2ded Compare March 27, 2024 16:00
@aymeric-roucher aymeric-roucher force-pushed the beam-search-visualizer branch from f8b2ded to 98f2768 Compare March 27, 2024 16:05
@aymeric-roucher
Copy link
Contributor Author

It's ok to merge on my side @gante !

@gante gante merged commit c9d2e85 into huggingface:main Mar 28, 2024
8 checks passed
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants