-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard error when ignoring tensors. (#27484) #29906
Merged
Merged
Commits on Mar 27, 2024
-
Hard error when ignoring tensors. (#27484)
* [WIP] Hard error when ignoring tensors. * Better selection/error when saving a checkpoint. - Find all names we should normally drop (those are in the transformers config) - Find all disjoint tensors (for those we can safely trigger a copy to get rid of the sharing before saving) - Clone those disjoint tensors getting rid of the issue - Find all identical names (those should be declared in the config but we try to find them all anyway.) - For all identical names: - If they are in the config, just ignore them everything is fine - If they are not, warn about them. - For all remainder tensors which are shared yet neither identical NOR disjoint. raise a hard error. * Adding a failing test on `main` that passes here. * We don't need to keep the subfolder logic in this test. * Apply suggestions from code review Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e7e3290 - Browse repository at this point
Copy the full SHA e7e3290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 528ad72 - Browse repository at this point
Copy the full SHA 528ad72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c4aaf5 - Browse repository at this point
Copy the full SHA 5c4aaf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 270e6ea - Browse repository at this point
Copy the full SHA 270e6eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cd1593 - Browse repository at this point
Copy the full SHA 7cd1593View commit details -
Configuration menu - View commit details
-
Copy full SHA for d561bef - Browse repository at this point
Copy the full SHA d561befView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5bec8f - Browse repository at this point
Copy the full SHA e5bec8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71f1f67 - Browse repository at this point
Copy the full SHA 71f1f67View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d915cc5 - Browse repository at this point
Copy the full SHA d915cc5View commit details
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e7a3186 - Browse repository at this point
Copy the full SHA e7a3186View commit details -
Configuration menu - View commit details
-
Copy full SHA for 455b478 - Browse repository at this point
Copy the full SHA 455b478View commit details -
Update .github/workflows/self-scheduled.yml
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a053ec7 - Browse repository at this point
Copy the full SHA a053ec7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7974f97 - Browse repository at this point
Copy the full SHA 7974f97View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.