Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: replace torch.testing.assert_allclose by torch.testing.assert_close #29915

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

gante
Copy link
Member

@gante gante commented Mar 27, 2024

What does this PR do?

Replaces torch.testing.assert_allclose by torch.testing.assert_close. The former is deprecated since torch 1.12 (and will be removed in a future version), with the later being its replacement

@gante gante requested a review from ArthurZucker March 27, 2024 18:07
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@gante gante merged commit 248d5d2 into huggingface:main Mar 28, 2024
18 checks passed
@gante gante deleted the torch_testing_assert_close branch March 28, 2024 09:53
itazap pushed a commit that referenced this pull request May 14, 2024
…rt_close` (#29915)

* replace torch.testing.assert_allclose by torch.testing.assert_close

* missing atol rtol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants