Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super tiny fix 12 typos about "with with" #29926

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Mar 28, 2024

Hi thanks for the library! Today when reading Bart's doc I see a with with typo, and when I want to search-and-modify it, I see a dozen of places having this, thus I made a quick replace about it.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

Rocketknight1 commented Mar 28, 2024

Hi @fzyzcjy, thanks for the update! Can you pip install transformers[quality] and then make style in the repo directory to run the code formatting tools? That should make the tests pass!

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Mar 29, 2024

Done!

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now - thanks for the fix!

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Mar 29, 2024

You are welcome and thanks for the lib!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1 Rocketknight1 merged commit 5ad7f17 into huggingface:main Mar 29, 2024
19 checks passed
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants